Remove AttributeList from Device Layer #41546
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #41546: Size comparison from c1f377d to 3665129 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41546 +/- ##
==========================================
- Coverage 51.04% 51.03% -0.02%
==========================================
Files 1386 1385 -1
Lines 100958 100920 -38
Branches 13061 13057 -4
==========================================
- Hits 51534 51501 -33
+ Misses 49424 49419 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It was only used in a single place and probably didn't belong in the device layer in the first place. Use a Span instead for DeviceInforProvider::SetUserLabelList. Also simplify DeviceInforProvider::ClearUserLabelList().
ksperling-apple
force-pushed
the
platform-attributelist
branch
from
3665129 to
f8b6393
Compare
|
PR #41546: Size comparison from c17e5ba to f8b6393 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It was only used in a single place and probably didn't belong in the device layer in the first place. Use a Span instead for DeviceInforProvider::SetUserLabelList.
Also simplify DeviceInforProvider::ClearUserLabelList().
Testing
Code is covered by existing tests.