[NXP] Rework common & mcxw71 ConfigurationManagerImpl.cpp #41553
+113
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ConfigurationManagerImpl.cpp files for the NXP platform, specifically targeting common and mcxw71 variants. The changes include updates to the DetermineBootReason signature, moving/updating GetBootReason to DetermineBootReason in mcxw71, adding missing functions to mcxw71, adding a macro, switching to mcxw ConfigurationManagerImpl for mcxw72, aligning the two files, and updating copyright/description. The changes also involve updating the copyright year in the header files and adding a define in the BUILD.gn file for mcxw71. I have added comments to address potential issues related to the reboot count, boot reason storage, and platform reset implementation.
chapongatien
approved these changes
Oct 21, 2025
andrei-menzopol
force-pushed
the
fix-bootreason
branch
from
fde34c3 to
c0cfbd9
Compare
|
PR #41553: Size comparison from a343518 to c0cfbd9 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41553 +/- ##
=======================================
Coverage 51.05% 51.05%
=======================================
Files 1385 1385
Lines 100884 100884
Branches 13055 13055
=======================================
Hits 51511 51511
Misses 49373 49373 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Move GetBootReason to DetermineBootReason * Align with nxp/common ConfigurationManagerImpl * Add nxp/common missing functions * Update copyright, description Signed-off-by: Andrei Menzopol <[email protected]>
…nagerImpl * Update DetermineBootReason signature, parameter type * Update copyright Signed-off-by: Andrei Menzopol <[email protected]>
Signed-off-by: Andrei Menzopol <[email protected]>
Signed-off-by: Andrei Menzopol <[email protected]>
…rmineBootReason Signed-off-by: Andrei Menzopol <[email protected]>
andrei-menzopol
force-pushed
the
fix-bootreason
branch
from
c0cfbd9 to
2ece262
Compare
|
PR #41553: Size comparison from b7fc5ab to 2ece262 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
andy31415
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the platform specific nxp/common and nxp/mcxw71 ConfigurationManagerImpl.cpp files.
Testing
Compilation and functional tests have been conducted internally (e.g commissioning, factory reset)