[NXP] Enable mcxw72 units tests #41554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Girardot <[email protected]>
Signed-off-by: Martin Girardot <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables MCXW72 unit tests, adds missing S200 crypto API definitions, and updates the unit test application to support the MCXW72 platform with OSA. I have identified a potential correctness issue where an incorrect error code is being returned, and a maintainability issue where entropy source is added in two places. I have provided specific feedback and code suggestions to address these issues.
|
PR #41554: Size comparison from 842aa2c to bdd22b1 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
dinabenamar
added
the
changing-git-submodules-on-purpose
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41554 +/- ##
==========================================
+ Coverage 51.04% 51.08% +0.03%
==========================================
Files 1384 1385 +1
Lines 100942 100901 -41
Branches 13059 13050 -9
==========================================
+ Hits 51526 51541 +15
+ Misses 49416 49360 -56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chapongatien
approved these changes
Oct 21, 2025
arkq
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add mcxw72 units tests support.
Added missing S200 crypto API definitions to resolve build failures.
Updated the unit test application to support the MCXW72 platform with OSA (Operating System Abstraction) support.
Ensured compatibility with platform-specific configurations and build environments.
Testing
build mcxw72 units tests:
west build -d build_matter_unit_tests_w72/ -b frdmmcxw72 src/test_driver/nxp/ -DCONFIG_MCUX_COMPONENT_middleware.freertos-kernel.config=n -Dcore_id=cm33_core0flash the binary to execute unit tests
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines