[Camera] Fix TC_WEBRTC_1_6 failure on not finding any WebRTC session to close#43565
Merged
mergify[bot] merged 2 commits intoproject-chip:masterfrom Mar 13, 2026
Merged
Conversation
… invoking EndSession The test case was failing as EndSession is called at step 9. Since on closing the browser popup, the peer connection gets closed. Some implementations can remove the session in CurrentSessions attribute on peer connection state switching to Closed/Disconnected. Hence it update TC_WEBRTC_1_6.py to ignore any NOT_FOUND status response for EndSession command. Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix a test failure in TC_WEBRTC_1_6 by ignoring a NotFound error when ending a WebRTC session. The change correctly identifies that the session might already be closed. However, the implementation of the error handling has a flaw where it could suppress other important errors. I've suggested a correction to ensure only NotFound errors are ignored, making the test more robust. Additionally, a minor style guide adherence point and a typo in a comment were noted.
|
PR #43565: Size comparison from e39dcc1 to cc319db Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43565 +/- ##
=======================================
Coverage 54.07% 54.07%
=======================================
Files 1548 1548
Lines 106701 106701
Branches 13309 13309
=======================================
Hits 57699 57699
Misses 49002 49002 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marktrayer
reviewed
Mar 12, 2026
marktrayer
approved these changes
Mar 12, 2026
|
PR #43565: Size comparison from e39dcc1 to 61c1715 Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
andy31415
approved these changes
Mar 12, 2026
andy31415
reviewed
Mar 12, 2026
pidarped
approved these changes
Mar 12, 2026
Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
chulspro
force-pushed
the
feature/contribution-camera-34
branch
from
61c1715 to
014552d
Compare
|
PR #43565: Size comparison from 4c2c574 to 014552d Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
marktrayer
pushed a commit
to marktrayer/connectedhomeip
that referenced
this pull request
Mar 13, 2026
…to close (project-chip#43565) * Fix TC_WEBRTC_1_6.py failure by ignoring NOT_FOUND status response on invoking EndSession The test case was failing as EndSession is called at step 9. Since on closing the browser popup, the peer connection gets closed. Some implementations can remove the session in CurrentSessions attribute on peer connection state switching to Closed/Disconnected. Hence it update TC_WEBRTC_1_6.py to ignore any NOT_FOUND status response for EndSession command. Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * Address review comment: Silence only NotFound interaction response Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> --------- Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Co-authored-by: s-gatti <s.gatti@samsung.com>
andy31415
pushed a commit
that referenced
this pull request
Mar 13, 2026
…to close (#43565) (#43578) * Fix TC_WEBRTC_1_6.py failure by ignoring NOT_FOUND status response on invoking EndSession The test case was failing as EndSession is called at step 9. Since on closing the browser popup, the peer connection gets closed. Some implementations can remove the session in CurrentSessions attribute on peer connection state switching to Closed/Disconnected. Hence it update TC_WEBRTC_1_6.py to ignore any NOT_FOUND status response for EndSession command. * Address review comment: Silence only NotFound interaction response --------- Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Co-authored-by: chulspro <chulspro.kim@samsung.com> Co-authored-by: s-gatti <s.gatti@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue: The test case fails with camera-app as EndSession is invoked at step 9.
Since the peer connection gets closed on closing the browser popup, some implementations can remove the session from CurrentSessions attribute on peer connection state switching to Closed/Disconnected. Hence TC_WEBRTC_1_6.py needs to be updated to ignore any NOT_FOUND status response for EndSession command at step 9.
Fixes: project-chip/certification-tool#905
Testing
Verified locally with Test Harness.