Add a stable attribute in api_maturity.xml test and fix up tests #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1168 +/- ##
=======================================
Coverage 65.41% 65.41%
=======================================
Files 171 171
Lines 18384 18384
Branches 3971 3971
=======================================
Hits 12025 12025
Misses 6359 6359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gen-tests has hardcoded indices for attribute comparisons. Adding more attributes for testing
would make tests fail.
This is a stand-alone change that adds an attribute to the maturity test cluster and fixes up the test to not
rely on ordering (or count for that matter).
This is in preparation of having maturity flags on attributes, which would require me to add more attributes to the test XML.