Skip to content

Adding unit tests to improve the code coverage of jest unit tests in ZAP #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adding unit tests to improve the code coverage of jest unit tests in ZAP #1652

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd7b2bd
Adding unit tests to improve the code coverage of jest unit tests in ZAP
brdandu Oct 1, 2025
0191521
ADding more tests
brdandu Oct 1, 2025
1545d55
- Fixing the cypress test coverage analysis, fixing the combination o…
brdandu Oct 3, 2025
9b52b98
- Having the combine script throw an error out if percentage of test …
brdandu Oct 3, 2025
809f5de
More cleanup
brdandu Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,13 @@ module.exports = {
],
coveragePathIgnorePatterns: [
'/node_modules/',
'<rootDir>/src-electron/generator/matter/darwin/Framework/CHIP/templates/helper.js'
]
'<rootDir>/src-electron/generator/matter/darwin/Framework/CHIP/templates/helper.js',
'<rootDir>/src-electron/generator/matter/app/zap-templates/templates/app/helper.js',
'<rootDir>/src-electron/generator/matter/app/zap-templates/templates/chip/ListHelper.js',
'<rootDir>/src-electron/generator/matter/app/zap-templates/templates/chip/helper.js',
'<rootDir>/src-electron/generator/matter/app/zap-templates/common/ClusterTestGeneration.js',
'<rootDir>/src-electron/generator/matter/chip-tool/templates/helper.js',
'<rootDir>/src-electron/generator/matter/chip-tool/templates/tests/helper.js'
],
testEnvironment: 'jsdom'
}
6 changes: 5 additions & 1 deletion src-electron/db/query-command.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1923,7 +1923,11 @@ async function selectCommandDetailsFromAllEndpointTypesAndClusters(
}

// Ordering of the results:
query = query + ' ORDER BY MANUFACTURER_CODE, CODE, NAME'
query =
query +
(doGroupBy
? ' ORDER BY MANUFACTURER_CODE, CODE, NAME'
: ' ORDER BY C.MANUFACTURER_CODE, C.CODE, C.NAME')

return dbApi.dbAll(db, query).then((rows) => rows.map(commandMapFunction))
}
Expand Down
1 change: 1 addition & 0 deletions src-electron/generator/helper-zcl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1776,6 +1776,7 @@ function isEnabled(enable) {
* @returns boolean
*/
function isCommandAvailable(clusterSide, incoming, outgoing, source, name) {
if (!clusterSide || !source) return false
if (0 == clusterSide.localeCompare(source)) {
return false
}
Expand Down
3 changes: 3 additions & 0 deletions src-electron/generator/matter/app/zap-templates/common/attributes/Accessors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,3 +128,6 @@ exports.meta = {
category: dbEnum.helperCategory.matter,
alias: ['common/attributes/Accessors.js', 'matter-accessors']
};

// Exports for unit testing
exports.isUnsupportedType = isUnsupportedType;
4 changes: 4 additions & 0 deletions src-electron/main-process/startup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1206,3 +1206,7 @@ exports.shutdown = shutdown
exports.quit = quit
exports.generateSingleFile = generateSingleFile
exports.upgradeZapFile = upgradeZapFile
exports.gatherFiles = gatherFiles
exports.noopConvert = noopConvert
exports.findZapFiles = findZapFiles
exports.outputFile = outputFile
3 changes: 3 additions & 0 deletions src-electron/rest/user-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1359,3 +1359,6 @@ exports.patch = [
callback: httpPatchUpdateBitOfFeatureMapAttribute
}
]

//Exports added for testing
exports.httpPostDuplicateEndpointType = httpPostDuplicateEndpointType
Loading