Resolve #244 Trigger handler to pass request data to flow #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixingwang
suggested changes
Jan 4, 2021
trigger/context.go
Outdated
|
|
||
| type valueKey string | ||
|
|
||
| const contextValueKey valueKey = "RequestParams" |
Contributor
There was a problem hiding this comment.
Should we rename RequestParams to data or values?
Contributor
Author
There was a problem hiding this comment.
renamed valueKey to "values"
…move 'vendor' path allows trigger developer to pass request parameters to handler w/o going through output mapper Resulve issue project-flogo#224 GetRef() in support package should remove 'vendor' path resubmit pull request to resolve issue project-flogo#224 Fix project-flogo#244 Trigger handler should provide option to pass request data to flow without explicit output mapping update per comments on issue project-flogo#246
lixingwang
approved these changes
Jan 5, 2021
Contributor
lixingwang
left a comment
lixingwang
left a comment
There was a problem hiding this comment.
@mellistibco Please have a look.
vijaynalawade
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
Fixes: #244
What is the current behavior?
What is the new behavior?
ref #244 for details