Skip to content

Conversation

@aditya-sengupta
Copy link
Collaborator

@aditya-sengupta aditya-sengupta commented Sep 28, 2020

  • The addition of a "vectorized" mode for wavelets.compute_wavelet(), so that the transform does not loop over all omegas and taus, i.e. the transform ideally takes less than O((num_omegas) * (num_taus))
  • Some numpy optimization
  • Expanded basic test, added data/test_vectorized_timing.py

Still a WIP, current issues/enhancements:

  • vectorized mode passes basic test, but causes S matrices to be singular (unclear why) in larger-scale test: to view the problem, run data/test_vectorized_timing.py
  • some substeps are still unvectorized and done naively in list comprehensions
  • vectorized mode does not call subfunctions: ideally after the above steps are done, the intermediate functions should be rewritten to work either on one (omega, tau) at a time or on all at once.

@aditya-sengupta aditya-sengupta self-assigned this Sep 28, 2020
Copy link
Collaborator

@tzdwi tzdwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome; I'm a little short on free time the next few weeks, but let me know once you're happy with everything and I'll test it all out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants