Skip to content

Conversation

@ShivamJha2436
Copy link
Contributor

What this PR does:

Updates the Contour documentation site to work with Hugo v0.128+ by replacing the deprecated resources.ToCSS function with toCSS. This ensures that contributors using modern Hugo versions can build the docs without errors.

Why this is needed:

With Hugo v0.128 and above, resources.ToCSS was removed. Anyone trying to build the docs with these versions would encounter the following error:

ERROR deprecated: resources.ToCSS was deprecated in Hugo v0.128.0 and subsequently removed. Use css.Sass instead.

Notes:

  • This change is fully backward compatible
  • No functionality or content of the docs has been altered

@ShivamJha2436 ShivamJha2436 requested a review from a team as a code owner October 21, 2025 16:34
@ShivamJha2436 ShivamJha2436 requested review from sunjayBhatia and tsaarni and removed request for a team October 21, 2025 16:34
@sunjayBhatia sunjayBhatia requested review from a team, davinci26 and wilsonwu and removed request for a team October 21, 2025 16:34
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.85%. Comparing base (27752f6) to head (0bba81c).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7270      +/-   ##
==========================================
+ Coverage   81.05%   81.85%   +0.79%     
==========================================
  Files         130      130              
  Lines       19669    15747    -3922     
==========================================
- Hits        15943    12889    -3054     
+ Misses       3442     2574     -868     
  Partials      284      284              

see 125 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@tsaarni tsaarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ShivamJha2436, thank you for your contribution!

It looks like the netlify build succeeded even though we’re still using quite an old version defined here:

HUGO_VERSION = "0.119.0"

Would you mind updating that as well?

@tsaarni tsaarni added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Oct 21, 2025
@ShivamJha2436
Copy link
Contributor Author

ShivamJha2436 commented Oct 21, 2025

Hi @ShivamJha2436, thank you for your contribution!

It looks like the netlify build succeeded even though we’re still using quite an old version defined here:

HUGO_VERSION = "0.119.0"

Would you mind updating that as well?

After updating to Hugo 0.152.0 with css.Sass, Netlify build fails due to GLIBC errors. We either need to update Netlify’s build image to Ubuntu 22.04+ or revert to the old toCSS pipeline; otherwise, the build won’t work.

@tsaarni
Copy link
Member

tsaarni commented Oct 21, 2025

Website build failed https://app.netlify.com/projects/projectcontour/deploys/68f7daa245e8a1000805ba77#L95

10:10:46 PM: $ hugo --gc --minify --buildFuture -b $DEPLOY_PRIME_URL
10:10:46 PM: hugo: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.33' not found (required by hugo) hugo: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.32' not found (required by hugo)
hugo: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by hugo) hugo: /lib/x86_64-linux-gnu/libstdc++.so.6: version GLIBCXX_3.4.29' not found (required by hugo)

I think this is because the OS image that netlify uses is old and new hugo binary would require bump to newer distro. Unfortunately I don't have access to our netlify portal to update that 😞 Lets try to revert the hugo version back to original and lets see if the old version handles the css.Sass call.

@tsaarni
Copy link
Member

tsaarni commented Oct 21, 2025

After updating to Hugo 0.152.0 with css.Sass, Netlify build fails due to GLIBC errors. We either need to update Netlify’s build image to Ubuntu 22.04+ or revert to the old toCSS pipeline; otherwise, the build won’t work.

Oops, sorry I missed your message when responding.

@ShivamJha2436
Copy link
Contributor Author

Hey @tsaarni, could you please approve the workflows when you get a chance?
I’ve tested the changes locally and everything looks good, so I think this PR should be good to go once the checks run successfully.

@tsaarni
Copy link
Member

tsaarni commented Oct 29, 2025

Hi @ShivamJha2436,
I’ve now updated the OS image to Ubuntu 24.04 at Netlify. Could you please add the latest Hugo to the PR again? Sorry for the back-and-forth with the versions 😊

Signed-off-by: ShivamJha2436 <[email protected]>
@ShivamJha2436
Copy link
Contributor Author

Thanks, @tsaarni! I’ve bumped Hugo to the latest version.

Copy link
Member

@tsaarni tsaarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That did the trick 🎉 Thanks @ShivamJha2436 for your contribution, really appreciate it.

@tsaarni tsaarni merged commit 2cf0e18 into projectcontour:main Oct 29, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants