Work around for initializing model._agent #1928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1928 +/- ##
==========================================
- Coverage 79.62% 79.38% -0.25%
==========================================
Files 15 15
Lines 1124 1130 +6
Branches 244 244
==========================================
+ Hits 895 897 +2
- Misses 198 202 +4
Partials 31 31 ☔ View full report in Codecov by Sentry. |
EwoutH
reviewed
Dec 26, 2023
|
Looks good! |
Co-authored-by: Ewout ter Hoeven <[email protected]>
EwoutH
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to the discussion in #1917, this PR contains a simple workaround if model._agent has not been set up because
super().__init__was not called when subclassingModel.It also fixes the bug mentioned in #1917 regarding
model.get_agents_of_type.