Add cgroups CPU quota and throttling metrics #1039
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add metrics related to CPU quotas and CPU throttling (Linux CFS bandwidth control), as well as the total CPU usage from Linux cgroups CPU accounting. Those metrics can be useful in multi-tenant cloud environments, in particular on Elastic Cloud nodes that use CPU boosting (vCPU credits). Signed-off-by: Michal Kapalka <[email protected]>
mkapalka
force-pushed
the
feature/add-cgroups-cpu-stats
branch
from
ad384a0 to
56195f7
Compare
|
@SuperQ @sysadmind it would be great if you could have a look at this PR and tell me if there's anything missing that I should add. Thanks in advance! |
|
Update: we have been using this branch successfully in production for quite some time now and those new metrics are very helpful, maybe it's worth merging this PR to make it easier for others to benefit from this as well? @SuperQ @sysadmind |
sysadmind
requested changes
Aug 13, 2025
| @@ -286,6 +286,66 @@ func NewNodes(logger *slog.Logger, client *http.Client, url *url.URL, all bool, | |||
| }, | |||
| Labels: defaultNodeLabelValues, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
I think these metrics should be converted to seconds. It's typical practice for prometheus metrics to always be in base units - https://prometheus.io/docs/practices/naming/#metric-names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metrics related to CPU quotas and CPU throttling (Linux CFS bandwidth control), as well as the total CPU usage from Linux cgroups CPU accounting. Those metrics can be useful in multi-tenant cloud environments, in particular on Elastic Cloud nodes that use CPU boosting (vCPU credits).