Use yaml.v3 to drop yaml.v2 direct dependency #1283
Conversation
|
can you rebase, resolve conflicts, and add a meaningful PR description with "what?" and "why?" for this change. |
This update replaces `yaml.v2` with `yaml.v3`. While the change does not directly impact blackbox_exporter functionality, `yaml.v3` provides improved features, better YAML 1.2 compliance, and security enhancements. Upgrading ensures the project stays aligned with best practices and benefits from the latest module improvements. Signed-off-by: Mikel Olasagasti Uranga <[email protected]>
mikelolasagasti
force-pushed
the
yaml.v3
branch
from
1ff6fe7 to
54bb996
Compare
| "github.com/prometheus/common/expfmt" | ||
| "github.com/prometheus/common/promslog" | ||
| "gopkg.in/yaml.v2" | ||
| "gopkg.in/yaml.v3" |
There was a problem hiding this comment.
I see @SuperQ's comment about blockers around upgrading to v3. go-yaml/yaml#665 (comment)
so I will hold and wait for @SuperQ's review on this before we merge this.
|
I would love to get this in and get the new features like comments, but looks like this is bit more involved then just updating the dependency. There is a behaviour change, and I am afraid that might break people's config. If and when we do this, we will need to either verify that this is not breaking config for users, and if it's breaking, we will need to give advance notice. also see: |
electron0zero
added
the
not-as-easy-as-it-looks
|
The upstream of Prometheus projects are moving from I will keep PR open, but it needs to be updated because we moved to |
2 participants
Use yaml.v3 to drop yaml.v2 direct dependency.
see https://github.com/go-yaml/yaml#compatibility