Adding the metric for certificate start #1382
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinivas Boga <[email protected]>
bseenu
force-pushed
the
cert-start-metric
branch
from
e74d27a to
a50ba2a
Compare
Author
|
@electron0zero can you please review this change, Thanks |
electron0zero
requested changes
Oct 29, 2025
Member
There was a problem hiding this comment.
This PR need few changes:
- please add the metric in grpc prober as well, so
grpc,http, andtcp. I think adding it into tcp will cover unix package as well but please audit. - please add or update test cases for all the probers where this metric should be present.
- please rebase and resolve the conflict.
- please update the PR desc to follow the new template: https://github.com/prometheus/blackbox_exporter/blob/master/.github/PULL_REQUEST_TEMPLATE.md
I will be give another review once these changes are made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case to monitor the certificate start time
Fixes #1386