feat: Implement byte matching in TCP query responses #1441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I tried to address the review comments from #1112 while rebasing. Let me know if I missed anything... |
Member
electron0zero
left a comment
electron0zero
left a comment
There was a problem hiding this comment.
few nits, lgtm 🙏🏼
needs a rebase and conflict resolved because of changes done in #1480.
bitfehler
force-pushed
the
expect_bytes
branch
from
ff505c6 to
8b4c6d0
Compare
Contributor
Author
|
@electron0zero thanks for the review, I hope this is what you had in mind! |
Member
There was a problem hiding this comment.
@bitfehler yup, this is what i had in my mind.
just one more ask for cleanup, I missed this in my last review. rest lgtm.
thanks for taking time and helping us push it over finish line 🙏🏼
Currently the exporter only supports lines, which breaks byte-oriented protocols such as the PostgreSQL StartTLS handshake. We also give a working example for Postgres in the sample configuration. Signed-off-by: Stanislav Grozev <[email protected]> Co-authored-by: Conrad Hoffmann <[email protected]>
bitfehler
force-pushed
the
expect_bytes
branch
from
8b4c6d0 to
b5ed4e2
Compare
Signed-off-by: Conrad Hoffmann <[email protected]>
bitfehler
force-pushed
the
expect_bytes
branch
from
c3a2ff2 to
fa91976
Compare
electron0zero
approved these changes
Oct 31, 2025
Signed-off-by: Suraj Nath <[email protected]>
Member
|
thank you for pushing it over finish line |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the exporter only supports lines, which breaks byte-oriented protocols such as the PostgreSQL StartTLS handshake.
We also give a working example for Postgres in the sample configuration.
This is an attempt to get #1112 over the finish line, as it has apparently been abandoned.
I would be just as happy with #1424, but maybe this is a bit more generic and flexible?