expfmt: Add NewTextParser function #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add expfmt.NewTextParser function that allows providing name validation scheme. Signed-off-by: Arve Knudsen <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a NewTextParser function to the expfmt package that allows clients to create TextParser instances with a specified name validation scheme. This addresses an omission where the TextParser.scheme field was made mandatory but no public constructor was provided for external clients to configure it properly.
- Adds
NewTextParser(model.ValidationScheme)constructor function - Updates existing code to use the new constructor instead of zero-value initialization
- Includes comprehensive test coverage for the new function
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
expfmt/text_parse.go |
Adds the new NewTextParser constructor function |
expfmt/text_parse_test.go |
Adds test for the new constructor and updates existing tests to use it |
expfmt/fuzz.go |
Updates fuzzing code to use the new constructor |
expfmt/decode.go |
Updates decoder to use the new constructor |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
expfmt.NewTextParserfunction that allows providing name validation scheme. I think this was an omission in #808, since it added the in practice mandatoryexpfmt.TextParser.schemefield ("Defaults to the invalid UnsetValidation"), but provides no way for clients outside of theexpfmtpackage to configure it. Throughexpfmt.NewTextParser,prometheus/commonclients can safely createexpfmt.TextParsers with a valid name validation scheme.I'm also including a test for
NewTextParser.