-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(om2): add native histograms to OpenMetrics2.0 #2634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krajorama
wants to merge
42
commits into
main
Choose a base branch
from
krajo/om2.0-native-histograms
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+230
−29
Open
Changes from 9 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
ddbace4
feat(om2): add native histograms to OpenMetrics2.0
krajorama 2f4113f
define the counter histogram model
krajorama a47ce0c
small fixes to histogram model
krajorama 10dc43d
update gauge histogram model
krajorama d12dfeb
wip: wip
krajorama 471a7dd
adjust wording
krajorama ec991a4
add abnf and presentation
krajorama dc308e2
updates
krajorama 57c6ab8
Add gauge histogram syntax
krajorama 32a65cf
clarify NaN and Inf and be permissive
krajorama 6968e00
fix from Arthur's comments
krajorama d95eed7
Merge branch 'main' into krajo/om2.0-native-histograms
krajorama 4da9670
test(om2): test that examples follow the spec and fix if not
krajorama 7965787
Update with exemplars
krajorama 0a944c4
Merge branch 'main' into krajo/om2.0-native-histograms
krajorama 52bd9e9
fix schema number allocation
krajorama 2b0fdcc
Only prohibit "le" label if there are classic buckets
krajorama 1dea11f
Make the requirement around NaN stronger in classic case.
krajorama 986380d
Fix classic bucket choice for exemplar
krajorama 3b9e078
Use native buckets instead of exponential buckets
krajorama bd82e1e
Define choice of classic vs native in terms of measurement
krajorama cbfe910
Require that all classic buckets are exposed in the text format
krajorama 16b4c50
Specify that empty native buckets should not be present or exposed
krajorama ca1d860
Mention reset when bucket count is too high
krajorama d65a48e
fix comment on "sum" in ABNF
krajorama 54c958c
Define the complex types for float histograms and rename deltas
krajorama ea81fd3
Remove the hard requirements on exemplars
krajorama 9d02b5b
sync gauge histogram to histogram in metric types
krajorama e972b87
Fix missing Gsum to Sum mapping
krajorama ae5c995
Merge branch 'main' into krajo/om2.0-native-histograms
krajorama abdeb9d
Merge main
krajorama 08f0e67
follow up rename of created value
krajorama 34e5a83
Merge remote-tracking branch 'origin/main' into krajo/om2.0-native-hi…
krajorama 13fe8d2
Merge remote-tracking branch 'origin/main' into krajo/om2.0-native-hi…
krajorama 2b4e403
Merge remote-tracking branch 'origin/main' into krajo/om2.0-native-hi…
krajorama 5c4f7a3
the zero bucket is not optional
krajorama 8f6e05e
add comment to spell out what the decimals mean
krajorama 5fabcff
Relax rules on what can be accepted as classic histogram for b compat
krajorama d4c452b
Remove float native histograms for now
krajorama 03be949
Discourage changing classic bucket thresholds in the model.
krajorama 3f5f6dc
Remove ambiguous statement on sum and count. require them.
krajorama e808703
Clarify what to do with buckets that have the value 0
krajorama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.