-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore(security.md): add more precisions regarding sec bugs reporting #2692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,12 +23,21 @@ This page describes the general security assumptions of Prometheus and the | |
| attack vectors that some configurations may enable. | ||
|
|
||
| As with any complex system, it is near certain that bugs will be found, some of | ||
| them security-relevant. If you find a _security bug_ please report it | ||
| privately to the maintainers listed in the MAINTAINERS of the relevant | ||
| repository and CC [email protected]. We will fix the issue as soon | ||
| as possible and coordinate a release date with you. You will be able to choose | ||
| if you want public acknowledgement of your effort and if you want to be | ||
| mentioned by name. | ||
| them security-relevant. If you discover a _security bug_ that has not yet been | ||
| publicly disclosed, please report it privately to the maintainers listed in the | ||
| MAINTAINERS of the relevant repository and CC [email protected]. | ||
| We will fix the issue as soon as possible and coordinate a release date with | ||
| you. You will be able to choose if you want public acknowledgement of your | ||
| effort and if you want to be mentioned by name. | ||
|
|
||
| For _security bugs_ that have already been publicly disclosed and require more than | ||
| just a dependency version bump to fix, please open a | ||
| [Bug report](https://github.com/prometheus/prometheus/issues) including all relevant | ||
| details, unless one has already been filed. | ||
|
|
||
| Most dependency version updates are handled automatically. However, if a _security bug_ | ||
| fix only requires updating a dependency version and our automation missed it, feel | ||
| free to submit the update directly. | ||
|
|
||
| ## Automated security scanners | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading order. Let's put this first.
Let's also explicitly mention "publicly disclosed, for example CVEs, ...".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A CVE can be embargoed and we want the private channel to be used for that. I'll use
public CVEsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea about the order, done.
we don't want it to be missed, I didn't put it at the end.