Skip to content

Conversation

mrueg
Copy link
Contributor

@mrueg mrueg commented Jun 22, 2025

The goal is to add rate limiting functionality to the endpoints exposed by exporter-toolkit.

Fixes: #330

@mrueg mrueg force-pushed the rate-limiting branch 6 times, most recently from adf73ed to d976f09 Compare June 22, 2025 21:55
@mrueg mrueg changed the title WIP: Add RateLimiting Add RateLimiting Jun 22, 2025
@mrueg mrueg changed the title Add RateLimiting feat: Add Rate Limiting Jun 22, 2025
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should we document that the current setup is Rate/Second?

@mrueg mrueg force-pushed the rate-limiting branch 4 times, most recently from 23d3b5a to 9457e0a Compare July 15, 2025 20:28
@mrueg mrueg force-pushed the rate-limiting branch 5 times, most recently from 29024ff to 1be4d94 Compare July 18, 2025 14:35
@mrueg
Copy link
Contributor Author

mrueg commented Aug 20, 2025

@SuperQ any outstanding thoughts on this?

@SuperQ
Copy link
Member

SuperQ commented Sep 5, 2025

Mind rebasing?

Adds a rate limiting mechanism, that will send HTTP/429 responses once a
defined limit is reached (Token Bucket)

Signed-off-by: Manuel Rüger <[email protected]>
@mrueg
Copy link
Contributor Author

mrueg commented Sep 5, 2025

@SuperQ thanks, rebased

@SuperQ SuperQ merged commit efac154 into prometheus:master Sep 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate Limiting for endpoints
2 participants