-
Notifications
You must be signed in to change notification settings - Fork 93
feat: Add Rate Limiting #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adf73ed
to
d976f09
Compare
SuperQ
requested changes
Jul 14, 2025
SuperQ
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should we document that the current setup is Rate/Second?
23d3b5a
to
9457e0a
Compare
SuperQ
reviewed
Jul 16, 2025
SuperQ
reviewed
Jul 16, 2025
29024ff
to
1be4d94
Compare
@SuperQ any outstanding thoughts on this? |
Mind rebasing? |
Adds a rate limiting mechanism, that will send HTTP/429 responses once a defined limit is reached (Token Bucket) Signed-off-by: Manuel Rüger <[email protected]>
@SuperQ thanks, rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to add rate limiting functionality to the endpoints exposed by exporter-toolkit.
Fixes: #330