Skip to content

Reduce the amount of logs by explicit handling of IO and Security exceptions #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reduce the amount of logs by explicit handling of IO and Security exceptions #1353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions collector/src/main/java/io/prometheus/jmx/JmxCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,19 +938,26 @@ public MetricSnapshots collect() {
jmxMBeanPropertyCache);

long start = System.nanoTime();
double error = 0;
double error = 1;
String errorMsg = "";

if ((config.startDelaySeconds > 0)
&& ((start - createTimeNanoSecs) / 1000000000L < config.startDelaySeconds)) {
throw new IllegalStateException("JMXCollector waiting for startDelaySeconds");
}
try {
scraper.doScrape();
error = 0;
} catch (java.io.IOException | java.lang.SecurityException e) {
errorMsg = e.getMessage();
} catch (Exception e) {
error = 1;
StringWriter sw = new StringWriter();
e.printStackTrace(new PrintWriter(sw));
LOGGER.error("JMX scrape failed: %s", sw);
errorMsg = sw.toString();
}

if (error == 1) {
LOGGER.error("JMX scrape failed: %s", errorMsg);
}

if (config.rulesCache != null) {
Expand Down