feat: track wei remainder from stETH share-to-ETH cast #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dianacarvalho1
left a comment
dianacarvalho1
left a comment
There was a problem hiding this comment.
Thank you @Troshchk ! I have some comments..
added 5 commits
January 13, 2026 12:01
Troshchk
force-pushed
the
kt/ENG-5305-handle-stETH-balance
branch
from
e7a82e1 to
7addfd3
Compare
added 5 commits
January 13, 2026 12:40
Collaborator
dianacarvalho1
left a comment
dianacarvalho1
left a comment
There was a problem hiding this comment.
Thank you @Troshchk ! I believe this not correct yet though 😕
… initial balance and add test for stETH pool
Contributor
tamaralipows
left a comment
tamaralipows
left a comment
There was a problem hiding this comment.
Thank you! Just minor readability comments! Logic looks good
Collaborator
dianacarvalho1
left a comment
dianacarvalho1
left a comment
There was a problem hiding this comment.
Thank @Troshchk ! Logic wise this looks good now! However do we know if this is still a problem with Lido v3?? 🫠 can we try to make a new test in a block after the update to confirm this?
Collaborator
dianacarvalho1
left a comment
dianacarvalho1
left a comment
There was a problem hiding this comment.
ok perfect now ✨ Thank you! Now let's deploy on monday (there is one addition we need to do here still and then we can merge this!)
|
This PR is included in version 0.154.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.