Bancor Adapter and Substream #112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, sell function, and buy function
…iceAt, and optimizations
…tions and minor fixes
…cor-adapter-and-substream
zizou0x
reviewed
Nov 19, 2024
Collaborator
zizou0x
left a comment
zizou0x
left a comment
There was a problem hiding this comment.
Looks good so far, I think we can simplify a lot by using the tycho-substreams SDK crate
Contributor
Author
|
@zizou0x I would like to suggest you also to use my logic to track ETH transfers in some global tycho file, along with extract_balance_deltas_from_tx (after applying the eventObject.at(index) logic instead of eventObject.field) |
Use the erc20 transfer utility in bancor to parse balance deltas from txs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zizou0x @kayibal
I can't spot what the problem is with the creation, as it gives this error with tycho:
Cannot find account with id: "..." where the ID is indeed the master vault address
Do you have any suggestions regarding this and, please, could you have a look?
I have tried with many different approaches, including the check by tx hash, but unfortunately it didn't help.
While testing via substreams gui, I am able to find the created component at that block and that tx with the given address, so I am sure the component is created.
--- EDIT:
The problem seems to be in extractor instance;
If component ID would not be found, runner.py would have failed with:
if comp_id not in components_by_id:
return TestResult.Failed(
f"'{comp_id}' not found in protocol components. "
f"Available components: {set(components_by_id.keys())}"
)
--- EDIT 2:
I also enabled skip_simulation flag to make sure the error was not related to a swap, feel free to re-enable it if necessary