feat: Implement Ethereum Rocketpool integration #321

ElusAegis · 2025-11-26T15:12:46Z

No description provided.

zizou0x

Just had a quick look at the overall logic and it looks good! I'll let @louise-poole review the protocol related things

substreams/ethereum-rocketpool/src/modules/4_map_protocol_changes.rs

substreams/ethereum-rocketpool/Cargo.toml

zizou0x · 2025-11-27T09:01:53Z

substreams/ethereum-rocketpool/src/utils.rs

@@ -0,0 +1,198 @@
+use substreams::prelude::BigInt;


Not necessarily in this PR but if we start using this in many protocols I wonder if we shouldn't move it to tycho-substreams to avoid code repetition

Literally had the same comment 😆

louise-poole

Nice! I'm very happy with the progress so far! Left a few comments, but overall the logic is sound and best practices were applied. Nice going 👍

substreams/ethereum-rocketpool/Cargo.toml

substreams/ethereum-rocketpool/integration_test.tycho.yaml

substreams/ethereum-rocketpool/src/modules/1_map_protocol_components.rs

louise-poole · 2025-11-27T09:06:18Z

substreams/ethereum-rocketpool/src/utils.rs

+/// Returns:
+///     `Vec<Attribute>`: A vector containing Attributes for each change detected in the tracked
+/// slots. Returns an empty vector if no changes are detected.
+pub fn get_changed_attributes(


I feel like it's warranted to move this into the tycho-substreams crate... it's used by a few protocols now. We should do that on a separate PR and merge it before updating this PR to use it.

louise-poole

I know we're discussing changing how we track liquidity, however these are the corrections that would be needed for the current implementation if we were to stick with using events and deltas. The clarification of using "total_eth" as the component balance applies either way though.

substreams/ethereum-rocketpool/src/modules/2_map_relative_component_balance.rs

substreams/ethereum-rocketpool/src/modules/3_store_balance.rs

substreams/ethereum-rocketpool/src/modules/4_map_protocol_changes.rs

ElusAegis · 2025-11-27T11:28:14Z

Thank you for the reviews, will address it later today

louise-poole

Looks great! I want to review the related simulation PR before I approve here (just to confirm we covered all necessary attributes etc). Left a few smaller comments in the meantime.

substreams/ethereum-rocketpool/src/modules/4_map_protocol_changes.rs

substreams/ethereum-rocketpool/src/modules/2_map_protocol_changes.rs

substreams/ethereum-rocketpool/src/constants.rs

substreams/ethereum-rocketpool/integration_test.tycho.yaml

louise-poole

Looks great! Just some minor suggestions. Will approve once I see simulation work properly (I think we're close!).

substreams/ethereum-rocketpool/src/modules/2_map_protocol_changes.rs

substreams/ethereum-rocketpool/build.rs

substreams/ethereum-rocketpool/src/modules/2_map_protocol_changes.rs

ElusAegis · 2025-12-04T11:55:03Z

I have additionally updated the svm-rs-builds dependency to resolve the CI failing.

louise-poole

One last small adjustment and then I think we're ready! Once this is done, let's sync this in dev?

substreams/ethereum-rocketpool/src/modules/1_map_protocol_components.rs

substreams/ethereum-rocketpool/src/modules/2_map_protocol_changes.rs

substreams/ethereum-rocketpool/substreams.yaml

louise-poole

Fantastic work on this 🔥

…nts and balance management (tests do not pass)

…plify error handling

…t information

… test configuration

…Result

…Capacity in simulation

…orage slots instead of deltas

…ad of V1_0

…tion

…m constants

…ol mapping

…update

…ames to snake case

… event handling post V1.2 deployment

…t mapping

…and asserting variable queue IDs

…or clarity

…ling

…clarity

…onsistency

…s in protocol mapping

…mapping

…act was activated and not from the point the V1.2 contract was deployed

…retrieval

…ndencies

…Rocket Pool Deposit Pool V1.2

…2 upgrade

…parameters

…rsion upgrades

…ot be running execution integration tests due to reasons explain in the integration_test

ElusAegis marked this pull request as ready for review November 26, 2025 16:48

zizou0x reviewed Nov 27, 2025

View reviewed changes

louise-poole reviewed Nov 27, 2025

View reviewed changes

ElusAegis force-pushed the ag/rocketpool-integration branch from e8b009b to 6559898 Compare November 29, 2025 12:56

louise-poole reviewed Dec 1, 2025

View reviewed changes

ElusAegis force-pushed the ag/rocketpool-integration branch from d01ed6e to 78ed6c8 Compare December 2, 2025 22:55

louise-poole reviewed Dec 3, 2025

View reviewed changes

ElusAegis force-pushed the ag/rocketpool-integration branch from f67accf to 64506e1 Compare December 3, 2025 15:24

ElusAegis requested a review from louise-poole December 4, 2025 12:59

louise-poole reviewed Dec 4, 2025

View reviewed changes

substreams/ethereum-rocketpool/src/modules/1_map_protocol_components.rs Outdated Show resolved Hide resolved

tvinagre reviewed Dec 4, 2025

View reviewed changes

substreams/ethereum-rocketpool/src/modules/1_map_protocol_components.rs Show resolved Hide resolved

tvinagre reviewed Dec 4, 2025

View reviewed changes

substreams/ethereum-rocketpool/src/modules/2_map_protocol_changes.rs Show resolved Hide resolved

tvinagre reviewed Dec 4, 2025

View reviewed changes

substreams/ethereum-rocketpool/substreams.yaml Show resolved Hide resolved

louise-poole approved these changes Dec 9, 2025

View reviewed changes

ElusAegis added 13 commits December 9, 2025 16:04

feat: Implement Ethereum Rocketpool integration with protocol compone…

1f7a2f3

…nts and balance management (tests do not pass)

feat: Refactor protocol component updates to use try_for_each and sim…

88d173f

…plify error handling

feat: Update Rocket Deposit Pool addresses to collect historical even…

890626c

…t information

feat: Add Rocketpool ABI path to rustfmt configuration

907c365

docs: Add clarification comment for skip_balance_check in integration…

7a23bec

… test configuration

feat: Update protocol type name to 'rocketpool_pool'

2481e48

feat: Rename function to map_relative_component_liquidity and remove …

fc67283

…Result

fix: have liquidity as a attribute, and total eth as a component balance

99af9df

fix: Filter protocol settings storage updates by RocketStorage address

b1219ab

feat: add attributes for RocketPool Queue to compute the getEffective…

44521d2

…Capacity in simulation

feat: do vault liquidity tracking by using deposit pool events and st…

d506072

…orage slots instead of deltas

feat: start indexing from the RocketDepositPool_V1_2 deployment inste…

35f401e

…ad of V1_0

feat: initialize protocol component with initial state values at crea…

0027346

…tion

ElusAegis added 29 commits December 9, 2025 16:04

refactor: a cleaner approach to providing initial parameters

6fe9424

fix: update substreams.yaml to be correctly parsed

b535d08

feat: add deposit_assign_enabled attribute for simulation

b2c3750

feat: add deposit_assign_maximum and deposit_assign_socialised_maximu…

b8ce22b

…m constants

chore: correct indentation for deposit assignment constants in protoc…

879ccf2

…ol mapping

docs: clarify reasoning for using storage slot approach in liquidity …

83cab6f

…update

feat: integrate RocketTokenRETH contract and update liquidity indexing

3103a22

chore: reorder functions to match logical call sequence

ec4850b

feat: unify ABI generation by reading from directory and converting n…

f40476e

…ames to snake case

docs: update documentation for minipool queue size updates to clarify…

5a890e5

… event handling post V1.2 deployment

feat: enhance minipool queue handling with queue_id based storage slo…

303cab0

…t mapping

feat: simplify queue handling by removing legacy queue storage slots …

94571a6

…and asserting variable queue IDs

feat: rename deposit contract liquidity to deposit contract balance f…

3225491

…or clarity

chore: making clippy happy

3c7537a

refactor: clarify comments regarding liquidity updates and queue hand…

5c6eb12

…ling

chore: making fmt happy

869a0fa

feat: rename deposit_assign_enabled to deposit_assigning_enabled for …

ba2add6

…clarity

feat: rename max_deposit_amount to maximum_deposit_pool_size for clarity

f3052af

feat: rename maximum_deposit_pool_size to max_deposit_pool_size for c…

7616acb

…onsistency

fix: support both rocket_network_balances v2 and v3, update reference…

511b926

…s in protocol mapping

fix: correct logic for filtering ProposalExecuted events in protocol …

64b37cd

…mapping

fix: update Rocket Deposit Pool to start indexing from the V1.2 contr…

32a7519

…act was activated and not from the point the V1.2 contract was deployed

fix: filter out reverted calls in protocol mapping for accurate data …

68cbee3

…retrieval

feat: add RocketpoolState support in protocol mapping and update depe…

830bcc0

…ndencies

fix: update mapping logic to find the transaction that activated the …

9e4a49f

…Rocket Pool Deposit Pool V1.2

fix: update documentation to clarify minipool queue behavior post V1.…

665016e

…2 upgrade

feat: add script to compute initial state values for substreams.yaml …

9ffac4a

…parameters

fix: update tycho dependencies in Cargo.lock for compatibility and ve…

0a3131c

…rsion upgrades

feat: finish updated execution integration, and explain why we will n…

af223ff

…ot be running execution integration tests due to reasons explain in the integration_test

ElusAegis force-pushed the ag/rocketpool-integration branch from 0848104 to af223ff Compare December 9, 2025 16:16

feat: Implement Ethereum Rocketpool integration #321

Are you sure you want to change the base?

feat: Implement Ethereum Rocketpool integration #321

Uh oh!

Conversation

ElusAegis commented Nov 26, 2025

Uh oh!

zizou0x left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zizou0x Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

louise-poole Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

louise-poole left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

louise-poole Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

louise-poole left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ElusAegis commented Nov 27, 2025

Uh oh!

louise-poole left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

louise-poole left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ElusAegis commented Dec 4, 2025

Uh oh!

louise-poole left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

louise-poole left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

louise-poole left a comment •

edited

Loading