Conversation
zizou0x
force-pushed
the
etherfi-adapter-and-substream
branch
from
816d018 to
16762a0
Compare
zizou0x
reviewed
Feb 12, 2025
Comment on lines
+412
to
+418
| // This test is currently broken due to a bug in runPoolBehaviour | ||
| // with constant price pools. | ||
| // function testPoolBehaviourEtherfi() public { | ||
| // bytes32[] memory poolIds = new bytes32[](1); | ||
| // poolIds[0] = bytes32(0); | ||
| // runPoolBehaviourTest(adapter, poolIds); | ||
| // } |
Collaborator
Author
There was a problem hiding this comment.
have you updated AdapterTest.sol runPoolBehaviourTest function so that it can manage constant prices?
| @@ -0,0 +1,322 @@ | |||
| syntax = "proto3"; | |||
| expected_components: | ||
| - id: "0x308861A430be4cce5502d0A12724771Fc6DaF216" # Liquidity Pool Address | ||
| tokens: | ||
| - "0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE" # ETH |
Collaborator
There was a problem hiding this comment.
We use address(0) for native eth
| let weeth_hex = format!("0x{}", hex::encode(WEETH_ADDRESS)); | ||
| let balance_deltas = block | ||
| .logs() | ||
| // .filter(|log| log.address()) // filter out logs that are not from the pool contract |
Collaborator
There was a problem hiding this comment.
What is this? do we need it or not?
| .get_last(format!("pool:{}", liquidity_pool_hex)) | ||
| .is_some() | ||
| { | ||
| substreams::log::info!("Liquidity Pool Deposit: +ETH {}", ev.amount); |
Collaborator
There was a problem hiding this comment.
Please remove substreams logs, we had issues with them in prod in the past. You can use them to debug but don't commit them
| - "etherfi_weeth_pool" | ||
|
|
||
| # A list of tests. | ||
| tests: |
Collaborator
There was a problem hiding this comment.
I couldn't run these tests, I think it's due to an archive node issue on my side. Can you confirm that they pass for you please? I'll try to fix my env and run them ASAP
| - tycho/evm/v1/utils.proto | ||
| importPaths: | ||
| - ../../proto | ||
| - ./proto |
Remove unused files and unwanted changes, make the compilation work, and address CI issues
dobertRowneySr
force-pushed
the
etherfi-adapter-and-substream
branch
from
ed5e71f to
7925cd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests fails due to the distance between the deployments and first deposit and wrap transactions.
etherfi_liquidity_pooldeployment at blockstart_block: 17664317, first deposit of ETH and mint of eETH atstop_block: 19796002start_block: 17664336, first wrap of eETH to weETH atstop_block: 19978024