feat: add external data source framework for non-composable hooks #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayibal
changed the title
zizou0x
reviewed
Jul 7, 2025
kayibal
force-pushed
the
ah/external-data-framework
branch
from
898c1be to
caeca20
Compare
This commit introduces a comprehensive framework for integrating external data sources into the Tycho simulation system, specifically designed to support non-composable hooks like Sorella's Angstrom integration. Key features: - Unified trait system for pull-based and push-based external data sources - Block synchronization strategies (Conservative, LatestOnly) - Speculative update handling with revert capability - Integration with ProtocolStreamExtension for seamless data flow - Support for both oracle-style and high-frequency data sources The framework enables protocols to provide off-chain data that enriches the main chain simulation with additional context such as signatures, oracle prices, or hook-specific data.
kayibal
force-pushed
the
ah/external-data-framework
branch
from
caeca20 to
cb1346f
Compare
|
|
||
| /// Error types for external data source operations | ||
| #[derive(Debug, thiserror::Error)] | ||
| pub enum ExternalDataError { |
Collaborator
There was a problem hiding this comment.
can we split these into several files please? 🥺 we can make a dir called external_data
Collaborator
Author
There was a problem hiding this comment.
Sure, this is just a draft. Unfortunaty we already have an integration based on it so if you need to move things I will ask you to take that into consideration (communicate what they need to change)
Collaborator
There was a problem hiding this comment.
oh boy 😬 you mean angstrom?? how complete is the implementation currently?
| let main_stream = ReceiverStream::new(rx).then({ | ||
| let decoder = decoder.clone(); // Clone the decoder for the closure | ||
| move |msg| { | ||
| // TODO: fix this clone workaround once we update tycho-common |
Collaborator
There was a problem hiding this comment.
update tycho-common with what?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary