Added functionality to use foreignSchema attribute of foreign-key tag… #1674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to create foreign key links to other databases in the same propel project
dereuromark
reviewed
May 11, 2021
| For other dbs, the <foreign-key foreignSchema="" > attribute can be used to link to databases within the same propel projec | ||
| */ | ||
| $db = explode(".", $name)[0]; | ||
| $name = explode(".", $name)[1]; |
Contributor
There was a problem hiding this comment.
[$db, $name] = explode(..., ..., 2) is the better syntax here.
Contributor
|
ping @surekap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference:
propelorm/Propel#191
The foreignSchema attribute of the foreign-key tag can be used on MySQL to link to other databases
According to the documentation provided at:
http://propelorm.org/documentation/cookbook/using-sql-schemas.html
In databases which support schemas (MySQL), there is no way to add foreign keys across databases.
This PR enables the foreign key relationships by using the database name as the schema name in these cases.
Tested with MySQL