feat(tokens-received-whitelisting): <- adds logic for that#68
Open
feat(tokens-received-whitelisting): <- adds logic for that#68
Conversation
gskapka
force-pushed
the
add-whitelisting-to-hooks
branch
from
675dee4 to
b6e69fb
Compare
gskapka
force-pushed
the
add-whitelisting-to-hooks
branch
from
b6e69fb to
17e9d2b
Compare
allemanfredi
requested changes
Dec 19, 2022
Collaborator
allemanfredi
left a comment
allemanfredi
left a comment
There was a problem hiding this comment.
LGTM! Just one mini question!
gskapka
force-pushed
the
add-whitelisting-to-hooks
branch
from
17e9d2b to
1d97744
Compare
This was referenced Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: A smart-contract which is registered as an ERC777 token recipient but is not whitelisted in this pToken contract will have not have its
tokensReceivedHookcalled, however mints & transfers will succeed.NOTE: A smart-contract that is whitelisted for having it's
tokensReceivedhook called in this pToken contract, but which is not registered as an ERC777 recipient, will not have the hook called, whether present or not, however transfers & mints will succeed.NOTE: A smart-contract that is whitelisted for having its
tokensReceivedhook called and is registered as an ERC777 token recipient, but which does not implement thetokensReceivedfunction will not be able to receive the pTokens, either by mints or transfers, because the hook function calls will revert since it doesn't exist.The various permutations of the above cases are tested in
./test/tokens-received-whitelist.test.js.