This repository was archived by the owner on Dec 3, 2023. It is now read-only.
feat: use custom url for binary download#351
Open
n1ru4l wants to merge 1 commit intoprzemyslawpluta:masterfrom
Open
feat: use custom url for binary download#351n1ru4l wants to merge 1 commit intoprzemyslawpluta:masterfrom
n1ru4l wants to merge 1 commit intoprzemyslawpluta:masterfrom
Conversation
ca72fc2 to
8168e99
Compare
Collaborator
|
Hey, @n1ru4l I understand your use case but I prefer to don't add a new environment variable it could be a thing we can avoid. What we can do to avoid the new environment variable is to check the response content type here: https://github.com/przemyslawpluta/node-youtube-dl/blob/master/lib/downloader.js#L29
If you can make that change I will happy to merge :) |
Author
|
That would not work as there are additional get parameter added here: node-youtube-dl/lib/downloader.js Line 89 in 6131a9a |
Collaborator
|
@n1ru4l not seeing that is an issue since query parameters are ignored by S3 files. e.g., https://s.microlink.io/kdsy_4QyLo6Kh61e8SOtMcxCtWg_.png?foo=bar&platform=darwin |
Author
|
But it will not append .exe properly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #338 which unfortunately got closed without being addressed.
This feature is necessary for people that are self-hosting the youtube-dl binary, e.g. on S3
cc @Kikobeats