Fix None-value guard in get_n_calculated_per_process for Zig backend#340
Draft
Copilot wants to merge 2 commits intozig-core-integrationfrom
Draft
Fix None-value guard in get_n_calculated_per_process for Zig backend#340Copilot wants to merge 2 commits intozig-core-integrationfrom
get_n_calculated_per_process for Zig backend#340Copilot wants to merge 2 commits intozig-core-integrationfrom
Conversation
…lues are None not missing) Co-authored-by: psathyrella <2960243+psathyrella@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Zig drop-in replacement for bcrham and ig-sw
Fix None-value guard in Mar 11, 2026
get_n_calculated_per_process for Zig backend
matsen
added a commit
that referenced
this pull request
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the Zig drop-in binary for bcrham,
process_out_errinitialises allbcrham_proc_info[i]['calcd']fields toNone(keys present, values absent) because the Zig binary emits no matching debug strings. The original guard checked for missing keys only, so during partition runsget_n_calculated_per_processwould crash withTypeError: unsupported operand type(s) for +=: 'float' and 'NoneType'.Changes
get_n_calculated_per_process: change key-presence check ('vtb' not in procinfo['calcd']) to.get('vtb') is None, which catches both absent keys andNonevalues — consistent with how the existing fallback comment describes the intent ("we lost some stdout somewhere")The guards added previously for
print_partition_dbgfoandcheck_wait_timesremain correct; this fixes the one unguarded caller that is exercised during partition (hierarchical agglomeration) rather than just annotation.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.