Open
Conversation
Signed-off-by: Joostlek <joostlek@outlook.com>
Owner
|
hm, while this might look good on paper but this has the potential of breaking roomba commands. I'd rather keep this on the ignore list. These are different objects in the end as you can see here (GMT+1 here): |
Owner
|
So: this needs to get tested with (ideally several) roombas, I don't expect them to deal well with request from the future or the distant past. |
Author
|
As long as the timestamp is the same I don't really see any problem tbf |
Author
|
But I am just not sure what the roomba itself expects |
Owner
|
yeah I glanced over the fact that we are timestamps here in the first place. My bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.astral.sh/ruff/rules/call-datetime-now-without-tzinfo/
Not 100% sure of this fix, feel free to propose something else