ECO Server Strange Loop Games Token authentication

[ArthurErlich]

Description

Strange Loops Games removed the user and pass authentication and replaced it with a token based authentication.

Checklist for all submissions

• [x ] Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you tested and reviewed your changes with confidence that everything works?
• Did you branch your changes and PR from that branch and not from your master branch?
  • If not, why?:

• You verify that the start command applied does not use a shell script
  • If some script is needed then it is part of a current yolk or a PR to add one
• The egg was exported from the panel

[danny6167]

I agree that we need to at least add token authentication, but don't they still support username/password authentication? This worked fine when I was testing last week.

[ArthurErlich]

Thanks for the replay,
I did a test, or rather i wanted the server running and id blocked me there that the authentication with password failed.
But it can be because i did not created a strange loop games account in the first place, It was created via Steam.

Tested it with:
SLG_username + Token
Steam_username + Token

@danny6167 Can you check if the login with username+password works? I will re add the login and make both option available if username and password still work.

[danny6167]

Yep I'll double check it tonight.

It would be great to move people to token only, but I also don't want to break existing installs if they are working.
Perhaps it would be best to retain the user/pass option but mention in the description that it's a deprecated option that will be removed in future.

[danny6167]

Can confirm - SLG username and password based authentication do still work

[ArthurErlich]

I changed the startup script. It will now switch between username/password or the token, depending on what is filled.

It looks like the Laravel code required_without:SLG_TOKEN does not work correctly—maybe a limitation of the parser in the panel? Furthermore, it parses the variable weirdly.

That is why I added a description text and warned the user that they should use either the token or the username and password.

[danny6167]

The way you've don't this startup is overly complicated.
You can include a flag only if it's set using syntax like this for example.
$([ -n "$SERVER_PASSWORD" ] && echo "-serverpassword=\"${SERVER_PASSWORD}\"")

And yes, unfortunately due to the way the validation rules are applied you can't use required_without: and other rules that need to consider cross-fields.

[ArthurErlich]

Thanks for the Reply and i wish for a good new year.

Yes, I know that my solution is a bit complicated. My Idea was to stop the user to fill both Password and Token field and getting an error.

But if you wish, I can also just change to your snipped and just echoing the start parameter when the field is filled in the config

$([ -n "$SERVER_PASSWORD" ] && echo "-serverpassword=\"${SERVER_PASSWORD}\"")

[danny6167]

Happy new year.
Yes, Please go ahead and change to that style of variable use.