Open
Conversation
jbruechert
requested changes
Mar 6, 2025
| errors = fetcher.fetch(Path(metadata_file)) | ||
| selector = sys.argv[1] | ||
| errors = 0 | ||
| if selector == "europe": |
Collaborator
There was a problem hiding this comment.
We generally have ci/fetch-feeds.py for fetching multiple regions. Maybe create a new similar script for this. Having too many special cases always bears the risk of breaking some of them with every change
Contributor
Author
There was a problem hiding this comment.
So instead of adding it here, creating a python script generate-continent-config.py ? Would be fine by me as well.
1Maxnet1
force-pushed
the
work/maxnet/create-europe-config
branch
from
32927a6 to
3374e6c
Compare
1Maxnet1
force-pushed
the
work/maxnet/create-europe-config
branch
from
b800599 to
e7beb62
Compare
1Maxnet1
force-pushed
the
work/maxnet/create-europe-config
branch
from
e7beb62 to
3642653
Compare
This could relatively easily be extended to allow for other areas
1Maxnet1
force-pushed
the
work/maxnet/create-europe-config
branch
from
3642653 to
404cc40
Compare
# Conflicts: # src/fetch.py # src/generate-motis-config.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I usually do not test the whole planet locally, but only certain countries or complete Europe. So this allows to generate a configuration file. The selection of countries is based on the list in #114 This could relatively easily be extended to allow for other areas, if there is demand. Also if you have any hints on how to do this more elegantly, I'm happy to hear it.