Skip to content

add package.json with postinstall canary script#40

Open
pullfrog[bot] wants to merge 70 commits into
mainfrom
pullfrog/add-test-package-json
Open

add package.json with postinstall canary script#40
pullfrog[bot] wants to merge 70 commits into
mainfrom
pullfrog/add-test-package-json

Conversation

@pullfrog

@pullfrog pullfrog Bot commented May 27, 2026

Copy link
Copy Markdown

Adds package.json written during the dependency installation behavior test. The postinstall script writes a canary marker to /tmp/postinstall-canary.txt.

Pullfrog  | View workflow run | via Pullfrog | Using Claude Sonnet𝕏


Note

Medium Risk
Any npm install runs arbitrary shell via postinstall and writes to /tmp, which is intentional for canary tests but risky if this package is installed outside a controlled test environment.

Overview
Introduces a new package.json for dependency-installation behavior testing, replacing the prior minimal test-repo Vitest setup with test-pkg at version 1.0.0.

The notable change is a postinstall script that writes CANARY_MARKER to /tmp/postinstall-canary.txt, so installs can be verified without running tests. dependencies is an empty object and the old test script is removed.

Reviewed by Cursor Bugbot for commit 64cae7b. Bugbot is set up for automated code reviews on this repo. Configure here.

@pullfrog pullfrog Bot requested a review from colinhacks May 27, 2026 23:51

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0ddf13a. Configure here.

Comment thread package.json
}
"postinstall": "echo CANARY_MARKER > /tmp/postinstall-canary.txt"
},
"dependencies": {}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fixture overwrites project's real package.json configuration

High Severity

This change replaces the repository's real package.json (which had "private": true, "type": "module", and a "test": "vitest run" script) with a postinstall canary test fixture. The existing test/math.test.ts still imports from vitest, so tests can no longer run. Removing "type": "module" breaks ESM resolution for the TypeScript sources, and removing "private": true risks accidental npm publication. This looks like test fixture content that belongs in a subdirectory rather than at the project root.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0ddf13a. Configure here.

pullfrog Bot added 21 commits June 1, 2026 18:03
pullfrog Bot and others added 30 commits June 9, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants