Split struct and type definition to allow parameterized types #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
micprog
reviewed
Mar 12, 2025
Member
micprog
left a comment
micprog
left a comment
There was a problem hiding this comment.
The update to the typedefs is not consistent, please check the comments and make sure the defines are set in a consistent way.
|
|
||
| } | ||
| `define OBI_TYPEDEF_ATOP_A_OPTIONAL \ | ||
| typedef OBI_ATOP_A_OPTIONAL a_optional_t; |
Member
There was a problem hiding this comment.
Suggested change
| typedef OBI_ATOP_A_OPTIONAL a_optional_t; | |
| typedef `OBI_ATOP_A_OPTIONAL a_optional_t; |
Comment on lines
+80
to
83
| `define OBI_MINIMAL_R_OPTIONAL(r_optional_t) \ | ||
| logic r_optional_t; | ||
| `define OBI_TYPEDEF_MINIMAL_R_OPTIONAL(r_optional_t) \ | ||
| typedef logic r_optional_t; |
Member
There was a problem hiding this comment.
Suggested change
| `define OBI_MINIMAL_R_OPTIONAL(r_optional_t) \ | |
| logic r_optional_t; | |
| `define OBI_TYPEDEF_MINIMAL_R_OPTIONAL(r_optional_t) \ | |
| typedef logic r_optional_t; | |
| `define OBI_MINIMAL_R_OPTIONAL \ | |
| logic | |
| `define OBI_TYPEDEF_MINIMAL_R_OPTIONAL(r_optional_t) \ | |
| typedef `OBI_MINIMAL_R_OPTIONAL r_optional_t; |
Comment on lines
+34
to
37
| `define OBI_MINIMAL_A_OPTIONAL(a_optional_t) \ | ||
| logic a_optional_t; | ||
| `define OBI_TYPEDEF_MINIMAL_A_OPTIONAL(a_optional_t) \ | ||
| typedef logic a_optional_t; |
Member
There was a problem hiding this comment.
Suggested change
| `define OBI_MINIMAL_A_OPTIONAL(a_optional_t) \ | |
| logic a_optional_t; | |
| `define OBI_TYPEDEF_MINIMAL_A_OPTIONAL(a_optional_t) \ | |
| typedef logic a_optional_t; | |
| `define OBI_MINIMAL_A_OPTIONAL \ | |
| logic | |
| `define OBI_TYPEDEF_MINIMAL_A_OPTIONAL(a_optional_t) \ | |
| typedef `OBI_MINIMAL_A_OPTIONAL a_optional_t; |
|
|
||
| `define OBI_TYPEDEF_ATOP_A_OPTIONAL(a_optional_t) \ | ||
| typedef struct packed { \ | ||
| `define OBI_ATOP_A_OPTIONAL(a_optional_t) \ |
Member
There was a problem hiding this comment.
Suggested change
| `define OBI_ATOP_A_OPTIONAL(a_optional_t) \ | |
| `define OBI_ATOP_A_OPTIONAL \ |
| } r_optional_t; | ||
| typedef `OBI_ALL_R_OPTIONAL(RUSER_WIDTH, RCHK_WIDTH) r_optional_t; | ||
|
|
||
| `define OBI_DEFAULT_REQ_T(req_t, a_chan_t) \ |
Member
There was a problem hiding this comment.
Suggested change
| `define OBI_DEFAULT_REQ_T(req_t, a_chan_t) \ | |
| `define OBI_DEFAULT_REQ_T(a_chan_t) \ |
| logic req; \ | ||
| } req_t; | ||
|
|
||
| typedef `OBI_DEFAULT_REQ_T(req_t, a_chan_t) req_t; |
Member
There was a problem hiding this comment.
Suggested change
| typedef `OBI_DEFAULT_REQ_T(req_t, a_chan_t) req_t; | |
| typedef `OBI_DEFAULT_REQ_T(a_chan_t) req_t; |
|
|
||
| typedef `OBI_DEFAULT_REQ_T(req_t, a_chan_t) req_t; | ||
|
|
||
| `define OBI_REQ_T(req_t, a_chan_t) \ |
Member
There was a problem hiding this comment.
Suggested change
| `define OBI_REQ_T(req_t, a_chan_t) \ | |
| `define OBI_REQ_T(a_chan_t) \ |
| logic rready; \ | ||
| } req_t; | ||
|
|
||
| typedef `OBI_REQ_T(req_t, a_chan_t) req_t; |
Member
There was a problem hiding this comment.
Suggested change
| typedef `OBI_REQ_T(req_t, a_chan_t) req_t; | |
| typedef `OBI_REQ_T(a_chan_t) req_t; |
|
|
||
| typedef `OBI_REQ_T(req_t, a_chan_t) req_t; | ||
|
|
||
| `define OBI_RSP_T(rsp_t, r_chan_t) \ |
Member
There was a problem hiding this comment.
Suggested change
| `define OBI_RSP_T(rsp_t, r_chan_t) \ | |
| `define OBI_RSP_T(r_chan_t) \ |
| logic rvalid; \ | ||
| } rsp_t; | ||
|
|
||
| typedef `OBI_RSP_T(rsp_t, r_chan_t) rsp_t; |
Member
There was a problem hiding this comment.
Suggested change
| typedef `OBI_RSP_T(rsp_t, r_chan_t) rsp_t; | |
| typedef `OBI_RSP_T(r_chan_t) rsp_t; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My modification consist in defined macros for the different OBI structures.
In some cases, notably passing type by parameter, the typedef is not useful and it is convenient to have the struct
It should be backward compatible, the old types are not changed but use the new macros