Skip to content

Conversation

aba-rechsteiner
Copy link

No description provided.

@aba-rechsteiner aba-rechsteiner requested a review from a team as a code owner January 27, 2023 11:03
@puppet-community-rangefinder
Copy link

apt::auth is a type

that may have no external impact to Forge modules.

apt is a class

Breaking changes to this file WILL impact these 250 modules (exact match):
Breaking changes to this file MAY impact these 47 modules (near match):

apt::params is a class

that may have no external impact to Forge modules.

This module is declared in 235 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there seems to be some extra bits (see in-line comment).

Comment on lines 408 to 412
$sources.each |$key, $value| {
apt::source { $key:
* => $value,
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look like a duplicate of the above block.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, I removed the block

@wolfaba
Copy link

wolfaba commented Jun 2, 2025

would it be possible to merge this PR? thank you

@bwitt
Copy link

bwitt commented Aug 24, 2025

Yes this seems useful!

@TheKrizz
Copy link

puppetlabs modules are really annoying!
Worst PR and Issue support ever.

@wolfaba
Copy link

wolfaba commented Sep 5, 2025

I have created Issue #1250 . thank you for merging

@shubhamshinde360
Copy link

Hey @aba-rechsteiner,

Could you please take a look at the rspec failure.

Also, it would be great if you could squash all the commit into one.

@wolfaba
Copy link

wolfaba commented Sep 15, 2025

@shubhamshinde360

aba-rechsteiner is not active anymore, you can contact me.

Also, it would be great if you could squash all the commit into one.

I could not use git squash, because there were already another commits between our commits, but I have branched main again, applied the patch of our all commits and commited as one commit and force pushed to branch "dev". Not it's one commit.

Could you please take a look at the rspec failure.

I hope I found it. If it will be OK, let me know please and I will squash the two commits again. Thank you.

Regards,
Robert.

@wolfaba
Copy link

wolfaba commented Sep 15, 2025

@shubhamshinde360
I hope now it should be correct. (I am sorry, for so many requests, I am no puppet neither ruby developer)
Thank you.

@shubhamshinde360
Copy link

No worries @wolfaba.
Looks like the issue is not going away. I'll take a look at it as well.

@wolfaba
Copy link

wolfaba commented Sep 15, 2025

Looks like the issue is not going away.

Maybe I found it now. There was no purge_default for auth.conf.d.

I'll take a look at it as well.

After this last try I really have no idea anymore. Thank you.

@wolfaba
Copy link

wolfaba commented Sep 15, 2025

OK, Run tests is OK now. I hope there are no any other errors :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants