Skip to content

ID v2 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ID v2 #126

wants to merge 3 commits into from

Conversation

ImTheSquid
Copy link
Member

No description provided.

@ImTheSquid ImTheSquid requested a review from rayhanadev June 19, 2025 19:02
Infinidoge
Infinidoge reviewed Jun 19, 2025
View reviewed changes
@ImTheSquid ImTheSquid removed the request for review from MatthewStanciu June 19, 2025 22:45
@ImTheSquid ImTheSquid requested a review from Infinidoge June 22, 2025 20:34
@Infinidoge
Copy link
Contributor

I still have concerns about security, as in practice this is more like 1-to-1.5-Factor Authentication instead of proper 2FA. But for the majority of things it's Good Enough, so the concerns aren't worth blocking over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Infinidoge Infinidoge Infinidoge approved these changes

@rayhanadev rayhanadev Awaiting requested review from rayhanadev rayhanadev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImTheSquid @Infinidoge