Skip to content

🐛 Fix GH Actions Run Behavior on PRs/Tags #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 31 commits into
base: develop
Choose a base branch
from
Open

🐛 Fix GH Actions Run Behavior on PRs/Tags #291

wants to merge 31 commits into from

Conversation

@WillXuCodes
Copy link
Member

@WillXuCodes WillXuCodes commented Jun 2, 2023 •
edited
Loading

Summary:

This PR does a couple things to the CI:

  • PRs no longer trigger an extra CI run.
  • Tags now trigger CI runs on pushes.

Test Plan:

  • Make sure normal pushing triggers CI
  • Make sure CI does not trigger on this PR.
  • Push a tag on this branch and see if CI triggers

@WillXuCodes WillXuCodes requested review from ayushuk and omegaStag June 2, 2023 01:51
@WillXuCodes
Copy link
Member Author

The CodeQL action ran on PR but that should be fine since that's not run on push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayushuk ayushuk Awaiting requested review from ayushuk

@omegaStag omegaStag Awaiting requested review from omegaStag

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WillXuCodes @ayushuk