Dojo-granted Event Awards#1061
Dojo-granted Event Awards#1061TheodorKitzenmaier wants to merge 23 commits intopwncollege:masterfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58a2a1f13c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
??? I didn't even touch it... |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02aceaf3c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "text": emoji_entry["text"], | ||
| "emoji": emoji_entry["emoji"], | ||
| "count": 1, | ||
| "count": emoji_entry["count"], |
There was a problem hiding this comment.
get_viewable_emojis now assumes every cached badge entry has a count field, but existing stats:emojis cache data produced by previous versions does not include that key. On an upgrade with persisted Redis data, accessing emoji_entry["count"] will raise KeyError and break scoreboard/hacker badge rendering until the emojis cache is recomputed. Please read this field defensively (for example defaulting to 1) to keep old cache payloads compatible.
Useful? React with 👍 / 👎.
2 participants
Adds the ability for select dojos to grant awards to users for participating in events. Also allows emojis to be foldered if a user has multiple of the same emoji in the
Nonecategory.