Skip to content

Conversation

@supercoolspy
Copy link
Contributor

@supercoolspy supercoolspy commented Nov 30, 2025

Needs to be avoided now since an unauthenticated url would be returned in the api
Fixes #984

@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
dojo_plugin/api/v1/workspace.py 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ConnorNelson
Copy link
Member

Good catch! Can we change it though so that:

  1. the user is allowed to get a url
  2. a dojo admin is allowed to get a url for another user (e.g. dojo.is_admin rather than is_admin)

And let's do this for all cases. We can later think about a user sharing the actual direct link that goes straight to their workspace.

@supercoolspy
Copy link
Contributor Author

1. the user is allowed to get a url

Do you mean by setting the user id field to their own user? Otherwise I believe that user_id is only set when you aren't trying to get a url for your account.

@ConnorNelson
Copy link
Member

I meant the normal base case (which is already covered).

@ConnorNelson ConnorNelson changed the title fix: do not allow logging in as other users besides desktop Site: Restrict access to other users' workspaces Dec 11, 2025
@ConnorNelson ConnorNelson merged commit 5cbcefa into pwncollege:master Dec 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Users can start services on other users' machines

2 participants