-
Notifications
You must be signed in to change notification settings - Fork 15
feat: support icon color #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (85.71%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
- Coverage 99.54% 99.16% -0.38%
==========================================
Files 31 31
Lines 1761 1803 +42
==========================================
+ Hits 1753 1788 +35
- Misses 8 15 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pulling the color-specific stuff off of #130
Application.theme_mode = 'dark'
, which will then determine the color of icons generated thereafter (but see note below)color_dark
/color_light
fields to theIcon
type to allow an icon to override the color that should be used in light/dark modes. (otherwise a dark gray / light gray default will be used in light / dark modes respectively)note that svg-colored icons don't currently change if the parent style sheet changes. This is just a generally harder thing to solve (and one of the few benefits of font-icons). However, we could, as magicgui does, attach QPallete change events here and auto-change icon colors in a future PR.