Skip to content

Update type hints in totp.py #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update type hints in totp.py #182

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a3ef2a
Update totp.py
discomethod Apr 15, 2025
8a1e9a0
Update totp.py
discomethod Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/pyotp/totp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def now(self) -> str:
"""
return self.generate_otp(self.timecode(datetime.datetime.now()))

def verify(self, otp: str, for_time: Optional[datetime.datetime] = None, valid_window: int = 0) -> bool:
def verify(self, otp: str, for_time: Optional[datetime.datetime] = None, valid_window: Optional[int] = 0) -> bool:
"""
Verifies the OTP passed in against the current time OTP.

Expand All @@ -77,13 +77,13 @@ def verify(self, otp: str, for_time: Optional[datetime.datetime] = None, valid_w
if for_time is None:
for_time = datetime.datetime.now()

if valid_window:
for i in range(-valid_window, valid_window + 1):
if utils.strings_equal(str(otp), str(self.at(for_time, i))):
return True
return False

return utils.strings_equal(str(otp), str(self.at(for_time)))
if not valid_window:
valid_window = 0

for i in range(-valid_window, valid_window + 1):
if utils.strings_equal(str(otp), str(self.at(for_time, i))):
return True
return False

def provisioning_uri(self, name: Optional[str] = None, issuer_name: Optional[str] = None, **kwargs) -> str:
"""
Expand Down