Conversation
Deploying logfire-docs with
|
| Latest commit: |
3a7e597
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://17e4a788.logfire-docs.pages.dev |
| Branch Preview URL: | https://vp-zizmor.logfire-docs.pages.dev |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 | ||
| with: | ||
| node-version: "23" | ||
| package-manager-cache: true # zizmor: ignore[cache-poisoning] -- Job does not produce release artifacts and does not have sensitive permissions |
Contributor
There was a problem hiding this comment.
🚩 New package-manager-cache input for setup-node added without root lockfile
The test-pyodide job adds package-manager-cache: true to actions/setup-node (.github/workflows/main.yml:192). This appears to be a renamed/new input in setup-node v6 (the old v4 used cache: 'npm'). The repo has a package-lock.json only in ./pyodide_test/, not at the root. If v6's auto-detection doesn't find the lockfile, caching may silently be skipped or produce a warning. This is non-critical since make test-pyodide runs cd pyodide_test && npm install which handles its own dependencies.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.