Add push_dataset helpers to the experimental API client#1848
Merged
Conversation
Deploying logfire-docs with
|
| Latest commit: |
82fd970
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://db4b6785.logfire-docs.pages.dev |
| Branch Preview URL: | https://hosted-datasets-pr3-push-dat.logfire-docs.pages.dev |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
dmontagu
force-pushed
the
hosted-datasets-pr3-push-dataset
branch
from
4aca180 to
9a0416e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alexmojaki
reviewed
Apr 9, 2026
alexmojaki
reviewed
Apr 9, 2026
alexmojaki
reviewed
Apr 9, 2026
alexmojaki
reviewed
Apr 9, 2026
- Fix NoneType inference in _get_dataset_type_args so Dataset[..., None]
no longer emits a {"type": "null"} schema (Devin review)
- Remove input_type/output_type/metadata_type overrides from push_dataset;
rely on the Dataset generic parameters instead
- Document that case-level evaluators round-trip through the API but are
not yet visible in the Logfire UI
- Reframe evaluations.md around local vs hosted datasets with logfire.configure
examples, and update pydantic-evals docs links
alexmojaki
approved these changes
Apr 10, 2026
These fields are no longer needed in the experimental dataset client. Removes parameters, logic, tests, and documentation references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
push_dataset(...)and asyncpush_dataset(...)to the experimental datasets API clientpydantic_evals.Dataset[...]instances and fall back to explicit overridesValidation
uv run ruff check logfire/experimental/api_client.py tests/test_datasets_client.pyuv run pyright logfire/experimental/api_client.py tests/test_datasets_client.pyuv run pytest tests/test_datasets_client.py -q