Skip to content

Prepare Logfire setup skills for public publication - #2342

Merged
strawgate merged 6 commits into
mainfrom
codex/validate-logfire-setup-skills
Sep 1, 2026
Merged

Prepare Logfire setup skills for public publication#2342
strawgate merged 6 commits into
mainfrom
codex/validate-logfire-setup-skills

Conversation

@strawgate

@strawgate strawgate commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make every Logfire setup skill pass Agent Skills validation
  • route the setup hub through directly fetchable application, infrastructure, eval, query, and UI skills
  • align Collector auth, host metrics, metadata, and AWS guidance with current first-party and OpenTelemetry documentation
  • document custom evaluator deserialization for hosted eval datasets
  • update the public docs copy prompt to the stable setup URL and regenerate the offline bundle

Validation

  • .venv/bin/python -m pytest tests/test_agent_setup_prompt.py tests/test_build_offline_skill_prompt.py (12 passed)
  • all four setup-related skills pass Agent Skills quick_validate.py
  • all relative Markdown references resolve locally
  • git diff --check

Rollout

This is the source change for pydantic/skills#54. The stable URL becomes live only after pydantic/unified-docs#245 and the follow-up publication allowlist/deployment; consumer PRs must wait for that live check.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: a51fae1a-d98f-4657-9afb-fcdcb3cebc04

📥 Commits

Reviewing files that changed from the base of the PR and between 63b3325 and 3fed6b7.

📒 Files selected for processing (2)
  • logfire/.agents/skills/logfire-instrumentation/SKILL.md
  • logfire/.agents/skills/logfire-setup-offline.md
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • pydantic/logfire (manual)
  • pydantic/pydantic-ai (manual)

Included review availability: Your plan provides up to 8 included reviews per hour; 1 remains after this review.


Important

Approval pending

CodeRabbit has no unresolved comments, but it has not reviewed the latest commit.

Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Updated two Logfire agent skill documents. The changes expand AI and agent framework coverage, clarify observability and monitoring scope, and route infrastructure-only monitoring and AI agent evaluation requests to dedicated skills.

Merge Risk: ⚪ Minimal · up to 3fed6

This change shortens skill metadata while preserving routing and updates the checked-in setup bundle; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: preparing the Logfire setup skills for public publication.
Description check ✅ Passed The description is directly related to the changeset. It explains the skill updates, routing, documentation alignment, offline bundle regeneration, and validation results.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/validate-logfire-setup-skills

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Comment thread docs/first-trace.md
Comment thread docs/index.md
@strawgate strawgate changed the title Fix Logfire skill metadata validation Prepare Logfire setup skills for public publication Sep 1, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Comment thread tests/test_agent_setup_prompt.py Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Comment thread tests/test_agent_setup_prompt.py Outdated
@strawgate
strawgate added this pull request to the merge queue Sep 1, 2026
Merged via the queue into main with commit d12dfc5 Sep 1, 2026
27 checks passed
@strawgate
strawgate deleted the codex/validate-logfire-setup-skills branch September 1, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant