Fix keyerror in querying capabilities (reported for AMD hardware) #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korijn
approved these changes
Dec 17, 2025
Vipitis
reviewed
Dec 17, 2025
| capabilities["usages"] = c_capabilities.usages | ||
|
|
||
| if c_capabilities.formats: | ||
| capabilities["formats"] = formats = [] |
Contributor
There was a problem hiding this comment.
just a side note on this syntax... the list mutability gets exploited here like a pointer. formats isn't used below this anymore... yet it still works.
I found this sorta confusing in python.
Collaborator
There was a problem hiding this comment.
Everything is pass by reference in python. It would be weird if capabilities["formats"] and formats were independent copies though right?
capabilities["formats"] = formats = [] is not short for:
capabilities["formats"] = []
formats = []It's short for:
formats = []
capabilities["formats"] = formatsThat's how I think about it at least.
Member
Author
There was a problem hiding this comment.
In this particular case the formats is indeed a temporary variable, to avoid the repetitive dict lookup for doing capabilities["formats"].append(str_val).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #783