Skip to content

Ensure selfcheck file inherits directory permissions #13528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amol-
Copy link

@amol- amol- commented Aug 6, 2025

When writing files to cache pip does copy the permissions from the cache directory, this is an expected behaviour to ensure that any user that has access to the cache has also access to its content.

Copying the permissions explicitly is necessary due to the use of adjacent_tmp_file which by virtue of tempfile.mkstemp (indirectly via NamedTemporaryFile) causes all files to be created with 600 permissions.

This is not happening for selfcheck/XXXXX by the way, which makes the selfcheck unaccessible by users different from the one that created the cache.

This PullRequest creates an helper method copy_directory_permissions which allows both the cache and the selfcheck file to share the same logic in copying directory permissions and thus ensure consistency in cache files permissions.

@amol- amol- marked this pull request as draft August 6, 2025 11:50
@amol- amol- force-pushed the selfcheck-permissions branch from 1db6780 to 2e4aaa2 Compare August 6, 2025 15:31
@amol- amol- marked this pull request as ready for review August 6, 2025 15:55
@notatallshaw
Copy link
Member

Hi @amol- thanks for your PR to pip. Please be aware it take the maintainers some time to review as we are all doing this on a volunteer basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants