Open
Conversation
DimitriPapadopoulos
force-pushed
the
__package__
branch
from
5654c54 to
a1d1016
Compare
DimitriPapadopoulos
force-pushed
the
__package__
branch
from
a1d1016 to
72295ed
Compare
| import sys | ||
|
|
||
| if not __package__: | ||
| if not __spec__ or not __spec__.parent: |
Contributor
Author
There was a problem hiding this comment.
I had to add the not __spec__ test to avoid this MyPy error:
src/pipx/__main__.py:4: error: Item "None" of "ModuleSpec | None" has no attribute "parent" [union-attr]
But then I doubt __main__.__spec__ can be None here. Perhaps disabel this MyPy error?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog.d/(if the patch affects the end users)Summary of changes
Removed deprecated
__package__, scheduled for removal in Python 3.15.Test plan
Just CI.