Skip to content

lint: add zizmor check #18156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lint: add zizmor check #18156

wants to merge 1 commit into from

Conversation

woodruffw
Copy link
Member

This adds zizmor to lint.in and runs it as part of bin/lint, i.e. make lint.

This in turn should shorten the loop for local testing. One downside to this is that I think it'll effectively run zizmor twice in CI -- once in the linting job and once again in the dedicated job. We could maybe disable this by adding a make local-lint or similar, or having bin/lint skip zizmor when CI=true.

CC @ewdurbin 🙂

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw requested a review from a team as a code owner May 19, 2025 18:03
@woodruffw woodruffw requested a review from ewdurbin May 19, 2025 18:09
@woodruffw woodruffw self-assigned this May 19, 2025
@di
Copy link
Member

di commented Jul 15, 2025

and once again in the dedicated job

Is there a reason to continue doing this if it's already run in the linting job?

@woodruffw
Copy link
Member Author

I believe @ewdurbin wanted it as part of their local development cycle, but it's definitely a bit duplicative with the zizmor job in CI.

@ewdurbin do you have a preference here? Another potential option here would be to remove zizmor.yml as a separate CI job and coalesce it into the rest of the listing steps, so that make lint would do the exact same thing both locally and remotely.

@di
Copy link
Member

di commented Jul 15, 2025

Ah, maybe I'm not being clear, what I'm saying is: is there any advantage to a separate zizmor job in CI if we can run zizmor in linting in CI?

@woodruffw
Copy link
Member Author

Whoops, my misunderstanding! Yeah, there's not much advantage -- the main thing that running zizmor separately "gets" you is integration with GitHub via SARIF, but I'm not sure how useful you all find that vs. just having it fail in CI with results 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants