Skip to content

Validate admin form email field#19308

Open
JacobCoffee wants to merge 12 commits intomainfrom
email-validation-admin-form-fix
Open

Validate admin form email field#19308
JacobCoffee wants to merge 12 commits intomainfrom
email-validation-admin-form-fix

Conversation

@JacobCoffee
Copy link
Member

@JacobCoffee JacobCoffee commented Jan 13, 2026

  • Validates on frontend and backend
  • Moves no_deliverability_check fixture into public namespace to be used in other modules

Fixes https://python-software-foundation.sentry.io/issues/7187418804

@JacobCoffee JacobCoffee requested a review from a team as a code owner January 13, 2026 22:59
@sentry
Copy link

sentry bot commented Jan 13, 2026

Sentry Issue: WAREHOUSE-PRODUCTION-2D0

@miketheman miketheman added the admin Features needed for the Admin UI (people running the site) label Jan 13, 2026
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff - one change requested, one question

@JacobCoffee
Copy link
Member Author

i dont like that PT004 recommends moving a function to private if it doesn't return. that seems wrong? anyway, 28cfef9 fixes that to conform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

admin Features needed for the Admin UI (people running the site)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants