Fix 2FA page columns overflowing at high display scale#19710
Open
Redslayer112 wants to merge 1 commit intopypi:mainfrom
Open
Fix 2FA page columns overflowing at high display scale#19710Redslayer112 wants to merge 1 commit intopypi:mainfrom
Redslayer112 wants to merge 1 commit intopypi:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18270
The first column of the 2FA page was using
flex-shrink: 0, preventingit from shrinking to share space with the second column. At high display
scale factors this caused the second column to overflow off screen.
Replaced with
flex: 1on both columns so they share horizontal spaceequally regardless of content size or display scale.
Note: reproducing this bug locally requires an account with both a security
key and an authenticator app configured. The fix is a one-line CSS change
replacing
flex-shrink: 0on the first column withflex: 1on both columns.