Split relayer sessions into separate threads #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/agent/services/lazer_exporter.rs
Outdated
| .await | ||
| { | ||
| tracing::error!("Error sending transaction to Lazer relayer session: {e:?}"); | ||
| // TODO: Under what circumstances would the channel be hosed and is it worth retry? |
There was a problem hiding this comment.
The channels are mpsc so I think the only way to receive error is if the channel is closed.
|
Thanks, going to make changes reflecting lazer agent review also. |
…azer-relayer-threads
ali-behjati
reviewed
Jun 10, 2025
src/agent/services/lazer_exporter.rs
Outdated
| let mut relayer_senders = vec![]; | ||
|
|
||
| for url in config.relayer_urls.iter() { | ||
| let (sender, receiver) = mpsc::channel(RELAYER_CHANNEL_CAPACITY); |
There was a problem hiding this comment.
you can use a broadcast::channel here instead of managing multiple single consumer channels
ali-behjati
approved these changes
Jun 10, 2025
|
Refactored to broadcast::channel in most recent commit. Will bump version if I end up wanting to deploy to test without needing anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should mirror the changes in the new lazer agent (both of which should be refactored into common code).